Skip to content

ORT 1.23.4 Cherry Picks#27338

Open
adrastogi wants to merge 1 commit intorel-1.23.4from
adrastogi/1.23.4-cherry-pick
Open

ORT 1.23.4 Cherry Picks#27338
adrastogi wants to merge 1 commit intorel-1.23.4from
adrastogi/1.23.4-cherry-pick

Conversation

@adrastogi
Copy link
Contributor

This PR adds the frameworkName field to critical Windows ML telemetry
events to ensure proper event attribution and prevent data loss.

The frameworkName field is added to ensure that Windows ML events are
not lost and do not require joins with events that might have been
emitted outside the scope of the time span the processing scripts check
for long-running apps/processes. This allows each event to be
self-contained with framework identification.

The following telemetry events now include the frameworkName field:

1. **SessionCreationStart** - Logs when session creation begins
2. **SessionCreation** - Logs session creation details including model
metadata
3. **RuntimeError** - Logs runtime errors (both DEBUG and release
builds)
4. **RuntimePerf** - Logs runtime performance metrics including total
runs and duration
5. **AutoEpSelection** - Logs automatic execution provider selection
policy and results
6. **ProviderOptions** - Logs execution provider configuration options

All events now include TraceLoggingString(ORT_CALLER_FRAMEWORK,
"frameworkName") to maintain consistent framework identification across
the telemetry pipeline.

---------

Co-authored-by: Angela Serrano Brummett <angelser@microsoft.com>
@tianleiwu
Copy link
Contributor

tianleiwu commented Feb 13, 2026

Please update the version to 1.23.4 in the following file and line:

static_assert(std::string_view(ORT_VERSION) == "1.23.3",

Also, please try our cherry-pick script: #27333. You need add label "release:1.23.4" to PRs (like 27256) to be cherry-picked, then run the script.

It could provide warning like

Checking for potential missing dependencies (conflicts)...
WARNING: In PR #27256 (5645b77...), file 'onnxruntime/core/platform/windows/telemetry.cc' was modified by commit 9486eedc4... (Record service in telemetry events (#27252)) which is not included in the cherry-pick list.

That means you might need cherry-pick dependency PR (like 27252) as well.

@adrastogi
Copy link
Contributor Author

adrastogi commented Feb 13, 2026

Please update the version to 1.23.4 in the following file and line:

static_assert(std::string_view(ORT_VERSION) == "1.23.3",

Also, please try our cherry-pick script: #27333. You need add label "release:1.23.4" to PRs (like 27256) to be cherry-picked, then run the script.

It could provide warning like

Checking for potential missing dependencies (conflicts)...
WARNING: In PR #27256 (5645b77...), file 'onnxruntime/core/platform/windows/telemetry.cc' was modified by commit 9486eedc4... (Record service in telemetry events (#27252)) which is not included in the cherry-pick list.

That means you might need cherry-pick dependency PR (like 27252) as well.

Thanks, @tianleiwu ! Didn't know about the script- I may abandon this PR and try it from scratch. I saw there was a version increment commit in this release branch already but didn't look closely (I assumed it may have already updated the static assert). I'll plan on making that change too.

I did see the additional logging field picked up as part of manually running git cherry-pick but manually edited it out when I was handling the merge conflict because it was not part of the sole PR that was mentioned as a servicing candidate. @angelser / @bmehta001, can you please confirm if the changes in #27252 should be part of the 1.23.4 servicing release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants